xushiyan commented on code in PR #5697:
URL: https://github.com/apache/hudi/pull/5697#discussion_r883449090
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/processor/maxwell/MaxwellJsonKafkaSourcePostProcessor.java:
##########
@@ -49,12 +48,15 @@
*/
public class MaxwellJsonKafkaSourcePostProcessor extends
JsonKafkaSourcePostProcessor {
- private static final Logger LOG =
LogManager.getLogger(MaxwellJsonKafkaSourcePostProcessor.class);
-
private static final ObjectMapper MAPPER = new ObjectMapper();
+ private final String databaseRegex;
+ private final String tableRegex;
+
public MaxwellJsonKafkaSourcePostProcessor(TypedProperties props) {
super(props);
+ databaseRegex = props.getString(Config.DATABASE_NAME_REGEX_PROP.key(),
null);
+ tableRegex = props.getString(Config.TABLE_NAME_REGEX_PROP.key());
Review Comment:
as a common practice, we should prefer `Option<String>` over `null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
