vinothchandar commented on a change in pull request #1421: [HUDI-724]
Parallelize getSmallFiles for partitions
URL: https://github.com/apache/incubator-hudi/pull/1421#discussion_r395410993
##########
File path:
hudi-client/src/main/java/org/apache/hudi/table/HoodieMergeOnReadTable.java
##########
@@ -374,16 +374,12 @@ public void finalizeWrite(JavaSparkContext jsc, String
instantTs, List<HoodieWri
sf.location = new
HoodieRecordLocation(FSUtils.getCommitTime(filename),
FSUtils.getFileId(filename));
sf.sizeBytes = getTotalFileSize(smallFileSlice);
smallFileLocations.add(sf);
- // Update the global small files list
- smallFiles.add(sf);
Review comment:
guess this is not needed anymore since we aggregate it into a map already..
(never liked this line. so lgtm)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
