nsivabalan commented on code in PR #5747:
URL: https://github.com/apache/hudi/pull/5747#discussion_r890199508
##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestUtils.java:
##########
@@ -103,10 +103,17 @@ public static HoodieTableMetaClient init(Configuration
hadoopConf, String basePa
}
public static HoodieTableMetaClient init(Configuration hadoopConf, String
basePath, HoodieTableType tableType,
- HoodieFileFormat baseFileFormat)
+ HoodieFileFormat baseFileFormat)
throws IOException {
+ return init(hadoopConf, basePath, tableType, baseFileFormat,
"org.apache.hudi.keygen.SimpleKeyGenerator", true);
Review Comment:
yes, but I don't want to add a boolean and then add an if block to
explicitly override the key gen value. If you have some compelling reason, let
me know. I can do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
