alexeykudinkin commented on code in PR #5737:
URL: https://github.com/apache/hudi/pull/5737#discussion_r891768115
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieBaseRelation.scala:
##########
@@ -128,24 +128,28 @@ abstract class HoodieBaseRelation(val sqlContext:
SQLContext,
*/
protected lazy val (tableAvroSchema: Schema, internalSchema: InternalSchema)
= {
val schemaResolver = new TableSchemaResolver(metaClient)
- val avroSchema = Try(schemaResolver.getTableAvroSchema) match {
- case Success(schema) => schema
- case Failure(e) =>
- logWarning("Failed to fetch schema from the table", e)
- // If there is no commit in the table, we can't get the schema
- // t/h [[TableSchemaResolver]], fallback to the provided
[[userSchema]] instead.
- userSchema match {
- case Some(s) => convertToAvroSchema(s)
- case _ => throw new IllegalArgumentException("User-provided schema
is required in case the table is empty")
- }
+ val avroSchema: Schema = schemaSpec.map(convertToAvroSchema).getOrElse {
+ Try(schemaResolver.getTableAvroSchema) match {
+ case Success(schema) => schema
+ case Failure(e) =>
+ logError("Failed to fetch schema from the table", e)
+ throw new HoodieSchemaException("Failed to fetch schema from the
table")
+ }
}
- // try to find internalSchema
- val internalSchemaFromMeta = try {
-
schemaResolver.getTableInternalSchemaFromCommitMetadata.orElse(InternalSchema.getEmptyInternalSchema)
- } catch {
- case _: Exception => InternalSchema.getEmptyInternalSchema
+
+ val internalSchema: InternalSchema = if (!isSchemaEvolutionEnabled) {
+ InternalSchema.getEmptyInternalSchema
Review Comment:
Correct. Users will now have to specify Schema Evolution config for both
writes and reads
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
