YannByron commented on PR #5436:
URL: https://github.com/apache/hudi/pull/5436#issuecomment-1149784093

   > 2. we write cdc blocks when writing, there is one exception is when the 
file slice is the first version, no cdc block is needed
   
   It's not enough. There are other similar scenarios that the cdc block is not 
needed  even if `HoodieMergeHandle` is called.
   
   
![image](https://user-images.githubusercontent.com/10036681/172601206-09484275-d347-4c89-9909-49cee6d4a52f.png)
   
   some codes like this. `recordsWritten == 0L || (recordsWritten == 
insertRecordsWritten)` represents the cases like: 
   1. the first version of file slice you mentioned;
   2. delete all the records belongs to the previous version of file slice;
   3. drop partition;
   4. insert overwrite;
   5. and others that satisfy the above predicate.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to