vinothchandar commented on a change in pull request #1431: [HUDI-65]commitTime 
rename to instantTime
URL: https://github.com/apache/incubator-hudi/pull/1431#discussion_r395962069
 
 

 ##########
 File path: 
hudi-cli/src/main/java/org/apache/hudi/cli/commands/SavepointsCommand.java
 ##########
 @@ -63,36 +63,36 @@ public String showSavepoints() throws IOException {
   }
 
   @CliCommand(value = "savepoint create", help = "Savepoint a commit")
-  public String savepoint(@CliOption(key = {"commit"}, help = "Commit to 
savepoint") final String commitTime,
+  public String savepoint(@CliOption(key = {"commit"}, help = "Commit to 
savepoint") final String instantTime,
 
 Review comment:
   this is specifically doing a savepoint for a commit.. so `commitTime` is 
actually apt

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to