danny0405 commented on code in PR #5788:
URL: https://github.com/apache/hudi/pull/5788#discussion_r894307614
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java:
##########
@@ -116,17 +117,19 @@
public HoodieMergeHandle(HoodieWriteConfig config, String instantTime,
HoodieTable<T, I, K, O> hoodieTable,
Iterator<HoodieRecord<T>> recordItr, String
partitionPath, String fileId,
TaskContextSupplier taskContextSupplier,
Option<BaseKeyGenerator> keyGeneratorOpt) {
- this(config, instantTime, hoodieTable, recordItr, partitionPath, fileId,
taskContextSupplier,
- hoodieTable.getBaseFileOnlyView().getLatestBaseFile(partitionPath,
fileId).get(), keyGeneratorOpt);
+ super(config, instantTime, partitionPath, fileId, hoodieTable,
taskContextSupplier);
+ Option<HoodieBaseFile> baseFileOp =
hoodieTable.getBaseFileOnlyView().getLatestBaseFile(partitionPath, fileId);
Review Comment:
If the only purpose is for logging, can we just add a tool method here for
`hoodieTable.getBaseFileOnlyView().getLatestBaseFile(partitionPath,
fileId).get()`
wrapping this code ? There is no need to refactor the constructors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
