yihua commented on code in PR #5842:
URL: https://github.com/apache/hudi/pull/5842#discussion_r895216454
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java:
##########
@@ -148,7 +148,7 @@ public static void main(String[] args) throws Exception {
}
configs = new ArrayList<>();
if (args.length > 9) {
- configs.addAll(Arrays.asList(args).subList(8, args.length));
+ configs.addAll(Arrays.asList(args).subList(9, args.length));
Review Comment:
nit: have a constant variable for `9`?
##########
hudi-spark-datasource/hudi-spark2/src/test/java/org/apache/hudi/internal/TestHoodieBulkInsertDataInternalWriter.java:
##########
@@ -104,7 +100,7 @@ public void testDataInternalWriter(boolean sorted, boolean
populateMetaFields) t
Option<List<String>> fileNames = Option.of(new ArrayList<>());
// verify write statuses
- assertWriteStatuses(commitMetadata.getWriteStatuses(), batches, size,
sorted, fileAbsPaths, fileNames);
+ assertWriteStatuses(commitMetadata.getWriteStatuses(), batches, size,
sorted, fileAbsPaths, fileNames,false);
Review Comment:
nit: space before `false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
