xicm opened a new pull request, #5874:
URL: https://github.com/apache/hudi/pull/5874

   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before 
opening a pull request.*
   
   ## What is the purpose of the pull request
   
   We check whether the rollback is successful by checking whether the file 
name contains commit instanceTime in testRollbackWithDeltaAndCompactionCommit, 
but the instanceTime string is too short to appear in file names.
   `
   2022-03-29T01:30:26.3550882Z org.opentest4j.AssertionFailedError: There 
files should have been rolled-back when rolling back commit 002 but are still 
remaining. Files: 
[file:/tmp/junit5890929166894435504/2015/03/16/00264b80-ca3f-4aaa-80fc-fedfe4c72ee5-0_1-1393-4266_001.parquet]
 ==> expected: <0> but was: <1>
   `
   
   This fix lengthens the instanceTime string and  filters the file with 
_instanceTime.
   
   ## Brief change log
   
   
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkMergeOnReadTableRollback.java
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test 
coverage.
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to