bvaradar commented on a change in pull request #1150: [HUDI-288]: Add support
for ingesting multiple kafka streams in a single DeltaStreamer deployment
URL: https://github.com/apache/incubator-hudi/pull/1150#discussion_r396128870
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -342,6 +361,32 @@ public static void main(String[] args) throws Exception {
*/
private transient DeltaSync deltaSync;
+ public DeltaSyncService(Config cfg, JavaSparkContext jssc, FileSystem fs,
HiveConf hiveConf,
Review comment:
minor : Looks like most of the code in this constructor is same as that of
existing constructor. Can you have one constructor call other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
