danny0405 commented on code in PR #5884:
URL: https://github.com/apache/hudi/pull/5884#discussion_r900100746
##########
hudi-common/src/main/java/org/apache/hudi/common/util/RetryHelper.java:
##########
@@ -47,13 +48,24 @@ public RetryHelper(long maxRetryIntervalMs, int
maxRetryNumbers, long initialRet
if (StringUtils.isNullOrEmpty(retryExceptions)) {
this.retryExceptionsClasses = new ArrayList<>();
} else {
- this.retryExceptionsClasses = Arrays.stream(retryExceptions.split(","))
- .map(exception -> (Exception) ReflectionUtils.loadClass(exception,
""))
- .map(Exception::getClass)
- .collect(Collectors.toList());
+ try {
+ this.retryExceptionsClasses = Arrays.stream(retryExceptions.split(","))
+ .map(exception -> (Exception)
ReflectionUtils.loadClass(exception, ""))
+ .map(Exception::getClass)
+ .collect(Collectors.toList());
+ } catch (HoodieException e) {
Review Comment:
Why this change ? If there is no default clazz for retryExceptions, should
skip this construction ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
