yuzhaojing commented on code in PR #5681:
URL: https://github.com/apache/hudi/pull/5681#discussion_r901287794
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/ClusteringPlanActionExecutor.java:
##########
@@ -102,6 +107,22 @@ public Option<HoodieClusteringPlan> execute() {
throw new HoodieIOException("Exception scheduling clustering", ioe);
}
}
+
+ if (config.isTableManagerEnabled() &&
config.getTableManagerConfig().getTableManagerActions().contains(ActionType.replacecommit.name()))
{
+ submitClusteringToService();
+ }
+
return planOption;
}
+
+ private void submitClusteringToService() {
+ HoodieTableMetaClient metaClient = table.getMetaClient();
+ List<String> instantsToSubmit = metaClient.getActiveTimeline()
+ .filterPendingReplaceTimeline()
Review Comment:
Yes, we will ensure clustering instant in replaceMetadata operationType. In
table manager service we can only deserialize replaceMetadata once.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/ScheduleCompactionActionExecutor.java:
##########
@@ -101,9 +105,14 @@ public Option<HoodieCompactionPlan> execute() {
} catch (IOException ioe) {
throw new HoodieIOException("Exception scheduling compaction", ioe);
}
- return Option.of(plan);
+ option = Option.of(plan);
}
- return Option.empty();
+
+ if (config.isTableManagerEnabled() &&
config.getTableManagerConfig().getTableManagerActions().contains(ActionType.compaction.name()))
{
Review Comment:
Good suggestion, update later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
