CTTY commented on code in PR #5734:
URL: https://github.com/apache/hudi/pull/5734#discussion_r901972537
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java:
##########
@@ -451,7 +451,7 @@ private static int doBootstrap(JavaSparkContext jsc, String
tableName, String ta
}
private static int rollback(JavaSparkContext jsc, String instantTime, String
basePath, Boolean rollbackUsingMarkers) throws Exception {
- SparkRDDWriteClient client = createHoodieClient(jsc, basePath,
rollbackUsingMarkers);
+ SparkRDDWriteClient client = createHoodieClient(jsc, basePath,
rollbackUsingMarkers, false);
Review Comment:
I've added a test for this change. Could you take a look again? Also I've
noticed a flink IT test has been failing:
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=9375&view=logs&j=3b6e910d-b98f-5de6-b9cb-1e5ff571f5de&t=30b5aae4-0ea0-5566-42d0-febf71a7061a&l=120490
I don't think my change would affect this test, but not sure if this is a
flaky test, could you also take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
