loukey-lj commented on PR #5877: URL: https://github.com/apache/hudi/pull/5877#issuecomment-1162546373
> Thanks, i would suggest to keep it as it is in order to be null-safe, or we should check all the code paths that use the option for null checking. For example, such validation now throws NPE: `conf.getString(FlinkOptions.KEYGEN_CLASS_NAME).equals(TimestampBasedAvroKeyGenerator.class.getName()` Done. Thanks for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
