danny0405 commented on code in PR #5890:
URL: https://github.com/apache/hudi/pull/5890#discussion_r904487370
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringPlanSourceFunction.java:
##########
@@ -75,7 +74,7 @@ public void open(Configuration parameters) throws Exception {
public void run(SourceContext<ClusteringPlanEvent> sourceContext) throws
Exception {
for (HoodieClusteringGroup clusteringGroup :
clusteringPlan.getInputGroups()) {
LOG.info("ClusteringPlanSourceFunction cluster " + clusteringGroup + "
files");
- sourceContext.collect(new
ClusteringPlanEvent(this.instant.getTimestamp(),
ClusteringGroupInfo.create(clusteringGroup),
clusteringPlan.getStrategy().getStrategyParams()));
Review Comment:
Execute clustering plan for instant {} as {} file slices ?
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringPlanOperator.java:
##########
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.sink.clustering;
+
+import org.apache.hudi.avro.model.HoodieClusteringGroup;
+import org.apache.hudi.avro.model.HoodieClusteringPlan;
+import org.apache.hudi.common.model.ClusteringGroupInfo;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.common.util.ClusteringUtils;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.table.HoodieFlinkTable;
+import org.apache.hudi.util.ClusteringUtil;
+import org.apache.hudi.util.FlinkTables;
+import org.apache.hudi.util.StreamerUtil;
+
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.streaming.api.operators.AbstractStreamOperator;
+import org.apache.flink.streaming.api.operators.OneInputStreamOperator;
+import org.apache.flink.streaming.api.operators.Output;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+
+/**
+ * Operator that generates the clustering plan with pluggable strategies on
finished checkpoints.
+ *
+ * <p>It should be singleton to avoid conflicts.
+ */
+public class ClusteringPlanOperator extends
AbstractStreamOperator<ClusteringPlanEvent>
+ implements OneInputStreamOperator<Object, ClusteringPlanEvent> {
+
+ /**
+ * Config options.
+ */
+ private final Configuration conf;
+
+ /**
+ * Meta Client.
+ */
+ @SuppressWarnings("rawtypes")
+ private transient HoodieFlinkTable table;
+
+ public ClusteringPlanOperator(Configuration conf) {
+ this.conf = conf;
+ }
+
+ @Override
+ public void open() throws Exception {
+ super.open();
+ this.table = FlinkTables.createTable(conf, getRuntimeContext());
+ // when starting up, rolls back all the inflight clustering instants if
there exists,
+ // these instants are in priority for scheduling task because the
clustering instants are
+ // scheduled from earliest(FIFO sequence).
+ ClusteringUtil.rollbackClustering(table,
StreamerUtil.createWriteClient(conf, getRuntimeContext()));
+ }
+
+ @Override
+ public void processElement(StreamRecord<Object> streamRecord) {
+ // no operation
+ }
+
+ @Override
+ public void notifyCheckpointComplete(long checkpointId) {
+ try {
+ table.getMetaClient().reloadActiveTimeline();
+ scheduleClustering(table, checkpointId);
+ } catch (Throwable throwable) {
+ // make it fail-safe
+ LOG.error("Error while scheduling clustering plan for checkpoint: " +
checkpointId, throwable);
+ }
+ }
+
+ private void scheduleClustering(HoodieFlinkTable<?> table, long
checkpointId) {
+ // the first instant takes the highest priority.
+ Option<HoodieInstant> firstRequested = Option.fromJavaOptional(
+
ClusteringUtils.getPendingClusteringInstantTimes(table.getMetaClient()).stream()
+ .filter(instant -> instant.getState() ==
HoodieInstant.State.REQUESTED).findFirst());
+ if (!firstRequested.isPresent()) {
+ // do nothing.
+ LOG.info("No clustering plan for checkpoint " + checkpointId);
+ return;
+ }
+
+ String clusteringInstantTime = firstRequested.get().getTimestamp();
+
+ // generate clustering plan
+ // should support configurable commit metadata
+ Option<Pair<HoodieInstant, HoodieClusteringPlan>> clusteringPlanOption =
ClusteringUtils.getClusteringPlan(
+ table.getMetaClient(),
HoodieTimeline.getReplaceCommitRequestedInstant(clusteringInstantTime));
+
+ if (!clusteringPlanOption.isPresent()) {
+ // do nothing.
+ LOG.info("No clustering plan scheduled");
+ return;
+ }
+
+ HoodieClusteringPlan clusteringPlan =
clusteringPlanOption.get().getRight();
+
+ if (clusteringPlan == null || (clusteringPlan.getInputGroups() == null)
+ || (clusteringPlan.getInputGroups().isEmpty())) {
+ // do nothing.
+ LOG.info("Empty clustering plan for instant " + clusteringInstantTime);
+ } else {
+ HoodieInstant instant =
HoodieTimeline.getReplaceCommitRequestedInstant(clusteringInstantTime);
+ // Mark instant as clustering inflight
Review Comment:
`instant` can be reused because line 106 did the same thing.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringPlanOperator.java:
##########
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.sink.clustering;
+
+import org.apache.hudi.avro.model.HoodieClusteringGroup;
+import org.apache.hudi.avro.model.HoodieClusteringPlan;
+import org.apache.hudi.common.model.ClusteringGroupInfo;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.common.util.ClusteringUtils;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.table.HoodieFlinkTable;
+import org.apache.hudi.util.ClusteringUtil;
+import org.apache.hudi.util.FlinkTables;
+import org.apache.hudi.util.StreamerUtil;
+
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.streaming.api.operators.AbstractStreamOperator;
+import org.apache.flink.streaming.api.operators.OneInputStreamOperator;
+import org.apache.flink.streaming.api.operators.Output;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+
+/**
+ * Operator that generates the clustering plan with pluggable strategies on
finished checkpoints.
+ *
+ * <p>It should be singleton to avoid conflicts.
+ */
+public class ClusteringPlanOperator extends
AbstractStreamOperator<ClusteringPlanEvent>
+ implements OneInputStreamOperator<Object, ClusteringPlanEvent> {
+
+ /**
+ * Config options.
+ */
+ private final Configuration conf;
+
+ /**
+ * Meta Client.
+ */
+ @SuppressWarnings("rawtypes")
+ private transient HoodieFlinkTable table;
+
+ public ClusteringPlanOperator(Configuration conf) {
+ this.conf = conf;
+ }
+
+ @Override
+ public void open() throws Exception {
+ super.open();
+ this.table = FlinkTables.createTable(conf, getRuntimeContext());
+ // when starting up, rolls back all the inflight clustering instants if
there exists,
+ // these instants are in priority for scheduling task because the
clustering instants are
+ // scheduled from earliest(FIFO sequence).
+ ClusteringUtil.rollbackClustering(table,
StreamerUtil.createWriteClient(conf, getRuntimeContext()));
+ }
+
+ @Override
+ public void processElement(StreamRecord<Object> streamRecord) {
+ // no operation
+ }
+
+ @Override
+ public void notifyCheckpointComplete(long checkpointId) {
+ try {
+ table.getMetaClient().reloadActiveTimeline();
+ scheduleClustering(table, checkpointId);
+ } catch (Throwable throwable) {
+ // make it fail-safe
+ LOG.error("Error while scheduling clustering plan for checkpoint: " +
checkpointId, throwable);
+ }
+ }
+
+ private void scheduleClustering(HoodieFlinkTable<?> table, long
checkpointId) {
+ // the first instant takes the highest priority.
+ Option<HoodieInstant> firstRequested = Option.fromJavaOptional(
+
ClusteringUtils.getPendingClusteringInstantTimes(table.getMetaClient()).stream()
+ .filter(instant -> instant.getState() ==
HoodieInstant.State.REQUESTED).findFirst());
+ if (!firstRequested.isPresent()) {
+ // do nothing.
+ LOG.info("No clustering plan for checkpoint " + checkpointId);
+ return;
+ }
+
+ String clusteringInstantTime = firstRequested.get().getTimestamp();
+
+ // generate clustering plan
+ // should support configurable commit metadata
+ Option<Pair<HoodieInstant, HoodieClusteringPlan>> clusteringPlanOption =
ClusteringUtils.getClusteringPlan(
+ table.getMetaClient(),
HoodieTimeline.getReplaceCommitRequestedInstant(clusteringInstantTime));
+
+ if (!clusteringPlanOption.isPresent()) {
+ // do nothing.
+ LOG.info("No clustering plan scheduled");
+ return;
+ }
+
+ HoodieClusteringPlan clusteringPlan =
clusteringPlanOption.get().getRight();
+
+ if (clusteringPlan == null || (clusteringPlan.getInputGroups() == null)
+ || (clusteringPlan.getInputGroups().isEmpty())) {
+ // do nothing.
+ LOG.info("Empty clustering plan for instant " + clusteringInstantTime);
+ } else {
+ HoodieInstant instant =
HoodieTimeline.getReplaceCommitRequestedInstant(clusteringInstantTime);
+ // Mark instant as clustering inflight
+ table.getActiveTimeline().transitionReplaceRequestedToInflight(instant,
Option.empty());
+ table.getMetaClient().reloadActiveTimeline();
+
+ for (HoodieClusteringGroup clusteringGroup :
clusteringPlan.getInputGroups()) {
+ LOG.info("ClusteringPlanSourceFunction cluster " + clusteringGroup + "
files");
+ output.collect(new StreamRecord<>(
Review Comment:
The message `ClusteringPlanSourceFunction` is wrong, `Execute clustering
plan for instant {} as {} file slices` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
