wulei0302 commented on code in PR #5627:
URL: https://github.com/apache/hudi/pull/5627#discussion_r904506695
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/mor/MergeOnReadInputFormat.java:
##########
@@ -753,7 +761,9 @@ private Option<IndexedRecord> mergeRowWithLog(
String curKey) throws IOException {
final HoodieAvroRecord<?> record = (HoodieAvroRecord)
scanner.getRecords().get(curKey);
GenericRecord historyAvroRecord = (GenericRecord)
rowDataToAvroConverter.convert(tableSchema, curRow);
- return record.getData().combineAndGetUpdateValue(historyAvroRecord,
tableSchema);
+ // TODO IndexedRecord to HoodieRecord
Review Comment:
At that time, `TODO` was because `HoodieFlinkRecord` was not implemented.
Currently, Avro record is still used.
I will remove this `TODO` first, and wait for the later implementation of
`HoodieFlinkRecord`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
