KnightChess commented on code in PR #5610:
URL: https://github.com/apache/hudi/pull/5610#discussion_r905638745
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -225,8 +225,11 @@ object HoodieSparkSqlWriter {
genericRecords.map(gr =>
keyGenerator.getKey(gr).getPartitionPath).toJavaRDD().distinct().collect()
}
// Create a HoodieWriteClient & issue the delete.
+ val tableMetaClient = HoodieTableMetaClient.builder
+
.setConf(sparkContext.hadoopConfiguration).setBasePath(basePath.toString).build()
+ val schemaStr = new
TableSchemaResolver(tableMetaClient).getTableAvroSchema.toString
Review Comment:
for delete op, there has special logic in
https://github.com/apache/hudi/blob/master/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java#L1437
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -225,8 +225,11 @@ object HoodieSparkSqlWriter {
genericRecords.map(gr =>
keyGenerator.getKey(gr).getPartitionPath).toJavaRDD().distinct().collect()
}
// Create a HoodieWriteClient & issue the delete.
+ val tableMetaClient = HoodieTableMetaClient.builder
+
.setConf(sparkContext.hadoopConfiguration).setBasePath(basePath.toString).build()
+ val schemaStr = new
TableSchemaResolver(tableMetaClient).getTableAvroSchema.toString
Review Comment:
for delete op, there has special logic in
https://github.com/apache/hudi/blob/master/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java#L1437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
