danny0405 commented on code in PR #5912:
URL: https://github.com/apache/hudi/pull/5912#discussion_r905765888
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowDataParquetWriter.java:
##########
@@ -49,8 +49,7 @@ public HoodieRowDataParquetWriter(Path file,
HoodieRowDataParquetConfig parquetC
this.file = HoodieWrapperFileSystem.convertToHoodiePath(file,
parquetConfig.getHadoopConf());
this.fs = (HoodieWrapperFileSystem)
this.file.getFileSystem(FSUtils.registerFileSystem(file,
parquetConfig.getHadoopConf()));
- this.maxFileSize = parquetConfig.getMaxFileSize()
- + Math.round(parquetConfig.getMaxFileSize() *
parquetConfig.getCompressionRatio());
+ this.maxFileSize = Math.round(parquetConfig.getMaxFileSize() *
parquetConfig.getCompressionRatio());
this.writeSupport = parquetConfig.getWriteSupport();
Review Comment:
The logic is referenced from `HoodieBaseParquetWriter`, why you think it is
wrong, can you explain more details ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
