alexeykudinkin commented on code in PR #5966:
URL: https://github.com/apache/hudi/pull/5966#discussion_r906417856
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/row/HoodieInternalRowFileWriterFactory.java:
##########
@@ -68,14 +69,17 @@ private static HoodieInternalRowFileWriter
newParquetInternalRowFileWriter(
HoodieRowParquetWriteSupport writeSupport =
new HoodieRowParquetWriteSupport(table.getHadoopConf(),
structType, filter, writeConfig);
return new HoodieInternalRowParquetWriter(
- path, new HoodieRowParquetConfig(
+ path,
+ new HoodieParquetConfig<>(
writeSupport,
writeConfig.getParquetCompressionCodec(),
writeConfig.getParquetBlockSize(),
writeConfig.getParquetPageSize(),
writeConfig.getParquetMaxFileSize(),
writeSupport.getHadoopConf(),
- writeConfig.getParquetCompressionRatio()));
+ writeConfig.getParquetCompressionRatio(),
+ writeConfig.parquetDictionaryEnabled()
Review Comment:
This is the culprit
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/row/HoodieInternalRowFileWriterFactory.java:
##########
@@ -68,14 +69,17 @@ private static HoodieInternalRowFileWriter
newParquetInternalRowFileWriter(
HoodieRowParquetWriteSupport writeSupport =
new HoodieRowParquetWriteSupport(table.getHadoopConf(),
structType, filter, writeConfig);
return new HoodieInternalRowParquetWriter(
- path, new HoodieRowParquetConfig(
+ path,
+ new HoodieParquetConfig<>(
writeSupport,
writeConfig.getParquetCompressionCodec(),
writeConfig.getParquetBlockSize(),
writeConfig.getParquetPageSize(),
writeConfig.getParquetMaxFileSize(),
writeSupport.getHadoopConf(),
- writeConfig.getParquetCompressionRatio()));
+ writeConfig.getParquetCompressionRatio(),
+ writeConfig.parquetDictionaryEnabled()
Review Comment:
This was the culprit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
