vinothchandar commented on a change in pull request #1402: [WIP][HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#discussion_r398221409
########## File path: hudi-client/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java ########## @@ -58,6 +58,11 @@ public static final String DEFAULT_BLOOM_INDEX_FILTER_TYPE = BloomFilterTypeCode.SIMPLE.name(); public static final String HOODIE_BLOOM_INDEX_FILTER_DYNAMIC_MAX_ENTRIES = "hoodie.bloom.index.filter.dynamic.max.entries"; public static final String DEFAULT_HOODIE_BLOOM_INDEX_FILTER_DYNAMIC_MAX_ENTRIES = "100000"; + public static final String SIMPLE_BLOOM_INDEX_USE_CACHING_PROP = "hoodie.simple.bloom.index.use.caching"; Review comment: call it `SimpleBloom` when it does not use any bloom filters is very confusing.. Can we make it just SimpleIndex? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
