wulei0302 commented on code in PR #5627:
URL: https://github.com/apache/hudi/pull/5627#discussion_r909204683
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieMergeOnReadRDD.scala:
##########
@@ -303,7 +305,12 @@ class HoodieMergeOnReadRDD(@transient sc: SparkContext,
private def merge(curAvroRecord: GenericRecord, newRecord: HoodieRecord[_
<: HoodieRecordPayload[_]]): Option[IndexedRecord] = {
// NOTE: We have to pass in Avro Schema used to read from Delta Log file
since we invoke combining API
// on the record from the Delta Log
- toScalaOption(newRecord.getData.combineAndGetUpdateValue(curAvroRecord,
logFileReaderAvroSchema, payloadProps))
+ val combinedRecord = hoodieMerge.combineAndGetUpdateValue(new
HoodieAvroIndexedRecord(curAvroRecord), newRecord, logFileReaderAvroSchema,
payloadProps)
Review Comment:
Sure, it will be done in Step3.
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieMergeOnReadRDD.scala:
##########
@@ -303,7 +305,12 @@ class HoodieMergeOnReadRDD(@transient sc: SparkContext,
private def merge(curAvroRecord: GenericRecord, newRecord: HoodieRecord[_
<: HoodieRecordPayload[_]]): Option[IndexedRecord] = {
// NOTE: We have to pass in Avro Schema used to read from Delta Log file
since we invoke combining API
// on the record from the Delta Log
- toScalaOption(newRecord.getData.combineAndGetUpdateValue(curAvroRecord,
logFileReaderAvroSchema, payloadProps))
+ val combinedRecord = hoodieMerge.combineAndGetUpdateValue(new
HoodieAvroIndexedRecord(curAvroRecord), newRecord, logFileReaderAvroSchema,
payloadProps)
Review Comment:
cc @wzx140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
