yihua commented on code in PR #5048:
URL: https://github.com/apache/hudi/pull/5048#discussion_r911261912
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/HoodieWrapperFileSystem.java:
##########
@@ -986,7 +991,63 @@ public long getBytesWritten(Path file) {
file.toString() + " does not have a open stream. Cannot get the bytes
written on the stream");
}
+ protected boolean needCreateTempFile() {
+ return HDFS.getScheme().equals(fileSystem.getScheme());
+ }
+
+ /**
+ * Creates a new file with overwrite set to false. This ensures files are
created
+ * only once and never rewritten, also, here we take care if the content is
not
+ * empty, will first write the content to a temp file if
{needCreateTempFile} is
+ * true, and then rename it back after the content is written.
+ *
+ * @param fullPath File Path
+ * @param content Content to be stored
+ */
+ public void createImmutableFileInPath(Path fullPath, Option<byte[]> content)
+ throws HoodieIOException {
+ FSDataOutputStream fsout = null;
+ Path tmpPath = null;
+
+ boolean needTempFile = needCreateTempFile();
+
+ try {
+ if (!content.isPresent()) {
+ fsout = fileSystem.create(fullPath, false);
+ }
+
+ if (content.isPresent() && needTempFile) {
+ Path parent = fullPath.getParent();
+ tmpPath = new Path(parent, fullPath.getName() + TMP_PATH_POSTFIX);
+ fsout = fileSystem.create(tmpPath, false);
+ fsout.write(content.get());
+ }
+
+ if (content.isPresent() && !needTempFile) {
+ fsout = fileSystem.create(fullPath, false);
+ fsout.write(content.get());
+ }
Review Comment:
I think it's still readable after the changes and you may also add comments.
Regardless, changes not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
