xushiyan commented on code in PR #5854:
URL: https://github.com/apache/hudi/pull/5854#discussion_r912316766
##########
hudi-sync/hudi-adb-sync/src/main/java/org/apache/hudi/sync/adb/AdbSyncConfig.java:
##########
@@ -152,89 +109,101 @@ public class AdbSyncConfig extends HoodieSyncConfig {
.defaultValue(false)
.withDocumentation("Whether drop table before creation");
- public AdbSyncConfig() {
- this(new TypedProperties());
+ public AdbSyncConfig(Properties props) {
+ super(props);
+ }
+
+ @Override
+ public String getAbsoluteBasePath() {
+ return generateAbsolutePathStr(new Path(getString(META_SYNC_BASE_PATH)));
Review Comment:
`META_SYNC_BASE_PATH` is required by the jcommander args. It is user's
responsibility to set base path properly. but still i may validate this in
`HoodieSyncConfig` constructor to ensure non-empty is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
