yanghua commented on code in PR #6035:
URL: https://github.com/apache/hudi/pull/6035#discussion_r912860724
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java:
##########
@@ -129,8 +129,6 @@ public static class HiveSyncConfigParams {
public String bucketSpec;
@Parameter(names = {"--sync-comment"}, description = "synchronize table
comments to hive")
public Boolean syncComment;
- @Parameter(names = {"--with-operation-field"}, description = "Whether to
include the '_hoodie_operation' field in the metadata fields")
- public Boolean withOperationField; // TODO remove this as it's not used
Review Comment:
OK, I just have some concerns:
- Let's make one PR focus on one thing. Keep it simple. WDYT?
- Anytime we remove a public config option, we must consider compatibility
seriously. If there is a compatibility issue, a better choice is to make it
with `@Deprecated` and remove it after two major releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
