LinMingQiang commented on code in PR #5937:
URL: https://github.com/apache/hudi/pull/5937#discussion_r913058338
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/utils/TestData.java:
##########
@@ -638,49 +657,92 @@ public static void checkWrittenFullData(
*
* <p>Note: Replace it with the Flink reader when it is supported.
*
- * @param fs The file system
- * @param latestInstant The latest committed instant of current table
- * @param baseFile The file base to check, should be a directory
- * @param expected The expected results mapping, the key should be the
partition path
- * @param partitions The expected partition number
- * @param schema The read schema
+ * @param fs The file system
+ * @param baseFile The file base to check, should be a directory
+ * @param expected The expected results mapping, the key should be the
partition path
+ * @param partitions The expected partition number
+ * @param schema The read schema
+ * @param conf The conf of write
*/
public static void checkWrittenDataMOR(
- FileSystem fs,
- String latestInstant,
- File baseFile,
- Map<String, String> expected,
- int partitions,
- Schema schema) {
+ FileSystem fs,
+ File baseFile,
+ Map<String, String> expected,
Review Comment:
👌🏻
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/utils/TestUtils.java:
##########
@@ -70,6 +70,16 @@ public static String getLastDeltaCompleteInstant(String
basePath) {
.orElse(null);
}
+ public static String getLastCompletedCommitInstants(String basePath) {
+ final HoodieTableMetaClient metaClient = HoodieTableMetaClient.builder()
Review Comment:
👌🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
