boneanxs commented on code in PR #6028:
URL: https://github.com/apache/hudi/pull/6028#discussion_r913628893
##########
hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/HoodieDatasetBulkInsertHelper.java:
##########
@@ -182,8 +184,8 @@ public static Dataset<Row>
prepareHoodieDatasetForBulkInsertWithoutMetaFields(Da
allCols.addAll(metaFields);
allCols.addAll(originalFields);
- return rowsWithMetaCols.select(
-
JavaConverters.collectionAsScalaIterableConverter(allCols).asScala().toSeq());
+ return
bulkInsertPartitionerRows.repartitionRecords(rowsWithMetaCols.select(
Review Comment:
Checked bulk insert without row support can accept partitioner even if
populateMetaFields is false, I'm not sure why it's not support for bulk insert
as row, let me change this to see if tests can pass.
https://github.com/apache/hudi/blob/fbda4ad5bd7cfb8a06badbaaefafafe95ea93b6b/hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/DataSourceUtils.java#L200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
