codope commented on code in PR #4915:
URL: https://github.com/apache/hudi/pull/4915#discussion_r917264555
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -785,13 +785,14 @@ object DataSourceOptionsHelper {
def parametersWithReadDefaults(parameters: Map[String, String]): Map[String,
String] = {
// First check if the ConfigUtils.IS_QUERY_AS_RO_TABLE has set by
HiveSyncTool,
// or else use query type from QUERY_TYPE.
- val queryType = parameters.get(ConfigUtils.IS_QUERY_AS_RO_TABLE)
+ val paramsWithGlobalProps =
DFSPropertiesConfiguration.getGlobalProps.asScala.toMap ++ parameters
Review Comment:
if both `globalProps` and `parameters` have the same config, then global
props will be overridden right?
##########
hudi-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java:
##########
@@ -174,6 +174,11 @@ public static TypedProperties getGlobalProps() {
return globalProps;
}
+ public static TypedProperties addToGlobalProps(String key, String value) {
Review Comment:
Got it. I think we should really find a way to include `@VisibleForTesting`
annotation just like im hudi-flink module. Maybe you could take it up later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
