codope commented on code in PR #5771:
URL: https://github.com/apache/hudi/pull/5771#discussion_r917747692
##########
hudi-common/src/main/java/org/apache/hudi/keygen/constant/KeyGeneratorOptions.java:
##########
@@ -45,7 +45,7 @@ public class KeyGeneratorOptions extends HoodieConfig {
public static final ConfigProperty<String> RECORDKEY_FIELD_NAME =
ConfigProperty
.key("hoodie.datasource.write.recordkey.field")
- .defaultValue("uuid")
+ .noDefaultValue()
.withDocumentation("Record key field. Value to be used as the
`recordKey` component of `HoodieKey`.\n"
+ "Actual value will be obtained by invoking .toString() on the
field value. Nested fields can be specified using\n"
+ "the dot notation eg: `a.b.c`");
Review Comment:
+1
i'll add
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
