pratyakshsharma commented on a change in pull request #1452: [HUDI-740]Fix can
not specify the sparkMaster of cleans run command
URL: https://github.com/apache/incubator-hudi/pull/1452#discussion_r399679036
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -62,7 +63,9 @@ public static void main(String[] args) throws Exception {
SparkCommand cmd = SparkCommand.valueOf(command);
- JavaSparkContext jsc = SparkUtil.initJavaSparkConf("hoodie-cli-" +
command);
+ JavaSparkContext jsc = cmd == SparkCommand.CLEAN
Review comment:
@hddong I can see in SparkMain.java class that sparkMaster and sparkMemory
are both present in args of other command as well. For example -
1.
https://github.com/apache/incubator-hudi/blob/04449f33feb300b99750c52ec37f2561aa644456/hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java#L216
2.
https://github.com/apache/incubator-hudi/blob/04449f33feb300b99750c52ec37f2561aa644456/hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java#L234
Am I missing something here?
Also all these positional arguments will be changed to proper config objects
as per this PR (https://github.com/apache/incubator-hudi/pull/1174). You might
want to take a look at this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
