umehrot2 commented on a change in pull request #1427: [HUDI-727]: Copy default
values of fields if not present when rewriting incoming record with new schema
URL: https://github.com/apache/incubator-hudi/pull/1427#discussion_r399719119
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/util/HoodieAvroUtils.java
##########
@@ -168,7 +169,7 @@ public static GenericRecord
addHoodieKeyToRecord(GenericRecord record, String re
*/
public static Schema appendNullSchemaFields(Schema schema, List<String>
newFieldNames) {
List<Field> newFields = schema.getFields().stream()
- .map(field -> new Field(field.name(), field.schema(), field.doc(),
field.defaultValue())).collect(Collectors.toList());
+ .map(field -> new Field(field.name(), field.schema(), field.doc(),
field.defaultVal())).collect(Collectors.toList());
for (String newField : newFieldNames) {
newFields.add(new Schema.Field(newField, METADATA_FIELD_SCHEMA, "",
NullNode.getInstance()));
Review comment:
Shall we change this line as well to consistently use the object API ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
