wzx140 commented on code in PR #5629: URL: https://github.com/apache/hudi/pull/5629#discussion_r924551196
########## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/commmon/model/HoodieSparkRecord.java: ########## @@ -0,0 +1,276 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.commmon.model; + +import org.apache.hudi.HoodieInternalRowUtils; +import org.apache.hudi.common.config.TypedProperties; +import org.apache.hudi.common.model.HoodieKey; +import org.apache.hudi.common.model.HoodieOperation; +import org.apache.hudi.common.model.HoodieRecord; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.common.util.collection.Pair; +import org.apache.hudi.exception.HoodieException; +import org.apache.hudi.keygen.BaseKeyGenerator; +import org.apache.hudi.keygen.SparkKeyGeneratorInterface; +import org.apache.hudi.keygen.factory.HoodieSparkKeyGeneratorFactory; +import org.apache.hudi.util.HoodieSparkRecordUtils; + +import org.apache.avro.Schema; +import org.apache.avro.generic.IndexedRecord; +import org.apache.spark.sql.catalyst.CatalystTypeConverters; +import org.apache.spark.sql.catalyst.InternalRow; +import org.apache.spark.sql.types.DataType; +import org.apache.spark.sql.types.StructField; +import org.apache.spark.sql.types.StructType; + +import java.io.IOException; +import java.util.Arrays; +import java.util.HashMap; +import java.util.Map; +import java.util.Properties; + +import scala.Tuple2; + +import static org.apache.hudi.common.table.HoodieTableConfig.POPULATE_META_FIELDS; +import static org.apache.spark.sql.types.DataTypes.BooleanType; +import static org.apache.spark.sql.types.DataTypes.StringType; + +/** + * Spark Engine-specific Implementations of `HoodieRecord`. + */ +public class HoodieSparkRecord extends HoodieRecord<InternalRow> { + + // IndexedRecord hold its schema, InternalRow should also hold its schema + private final StructType structType; + + public HoodieSparkRecord(InternalRow data, StructType schema) { + super(null, data); + this.structType = schema; + } + + public HoodieSparkRecord(InternalRow data, StructType schema, Comparable orderingVal) { + super(null, data, orderingVal); + this.structType = schema; + } + + public HoodieSparkRecord(HoodieKey key, InternalRow data, StructType schema) { + super(key, data); + this.structType = schema; + } + + public HoodieSparkRecord(HoodieKey key, InternalRow data, StructType schema, Comparable orderingVal) { + super(key, data, orderingVal); + this.structType = schema; + } + + public HoodieSparkRecord(HoodieKey key, InternalRow data, StructType schema, HoodieOperation operation, Comparable orderingVal) { + super(key, data, operation, orderingVal); + this.structType = schema; + } + + public HoodieSparkRecord(HoodieSparkRecord record) { + super(record); + this.structType = record.structType; + } + + @Override + public HoodieRecord<InternalRow> newInstance() { + return new HoodieSparkRecord(this); + } + + @Override + public HoodieRecord<InternalRow> newInstance(HoodieKey key, HoodieOperation op) { + return new HoodieSparkRecord(key, data, structType, op, getOrderingValue()); + } + + @Override + public HoodieRecord<InternalRow> newInstance(HoodieKey key) { + return new HoodieSparkRecord(key, data, structType, getOrderingValue()); + } + + @Override + public void deflate() { + } + + @Override + public String getRecordKey(Option<BaseKeyGenerator> keyGeneratorOpt) { + if (key != null) { + return getRecordKey(); + } + return keyGeneratorOpt.isPresent() ? ((SparkKeyGeneratorInterface) keyGeneratorOpt.get()).getRecordKey(data, structType) : data.getString(HoodieMetadataField.RECORD_KEY_METADATA_FIELD.ordinal()); + } + + @Override + public String getRecordKey(String keyFieldName) { + if (key != null) { + return getRecordKey(); + } + Tuple2<StructField, Object> tuple2 = HoodieInternalRowUtils.getCachedSchemaPosMap(structType).get(keyFieldName).get(); + DataType dataType = tuple2._1.dataType(); + int pos = (Integer) tuple2._2; + return data.get(pos, dataType).toString(); + } + + @Override + public HoodieRecordType getRecordType() { + return HoodieRecordType.SPARK; + } + + @Override + public Object getRecordColumnValues(String[] columns, Schema schema, boolean consistentLogicalTimestampEnabled) { + return HoodieSparkRecordUtils.getRecordColumnValues(data, columns, structType, consistentLogicalTimestampEnabled); + } + + @Override + public HoodieRecord mergeWith(Schema schema, HoodieRecord other, Schema otherSchema, Schema writerSchema) throws IOException { Review Comment: HoodieRecordPayload do not need to hold its schema. Otherwise, additional expenses will be brought from schema. ########## hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieInternalRowUtils.scala: ########## @@ -188,29 +211,82 @@ object HoodieInternalRowUtils { schemaMap.get(schema) } + def getProjection(from: Schema, to: Schema): Projection = { + getCachedUnsafeProjection(getCachedSchema(from), getCachedSchema(to)) + } + private def getCachedProjection(from: StructType, to: StructType): Projection = { val schemaPair = (from, to) if (!projectionMap.contains(schemaPair)) { projectionMap.synchronized { if (!projectionMap.contains(schemaPair)) { - val projection = generateMutableProjection(from, to) + val utilsClazz = ReflectionUtils.getClass("org.apache.hudi.HoodieSparkProjectionUtils") Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
