yihua commented on code in PR #5470:
URL: https://github.com/apache/hudi/pull/5470#discussion_r925007018
##########
hudi-common/src/main/java/org/apache/hudi/common/util/HoodieTimer.java:
##########
@@ -30,7 +30,17 @@
public class HoodieTimer {
// Ordered stack of TimeInfo's to make sure stopping the timer returns the
correct elapsed time
- Deque<TimeInfo> timeInfoDeque = new ArrayDeque<>();
+ private final Deque<TimeInfo> timeInfoDeque = new ArrayDeque<>();
+
+ public HoodieTimer() {
+ this(false);
+ }
+
+ public HoodieTimer(boolean shouldStart) {
+ if (shouldStart) {
+ startTimer();
+ }
+ }
Review Comment:
Understood. I'm saying that `timer = new HoodieTimer().startTimer()` looks
obvious for starting the timer instead of looking into what the boolean
represents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
