CTTY commented on code in PR #5943:
URL: https://github.com/apache/hudi/pull/5943#discussion_r925173896


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/BaseFileOnlyRelation.scala:
##########
@@ -91,7 +93,10 @@ class BaseFileOnlyRelation(sqlContext: SQLContext,
       hadoopConf = 
HoodieDataSourceHelper.getConfigurationWithInternalSchema(new 
Configuration(conf), requiredSchema.internalSchema, metaClient.getBasePath, 
validCommits)
     )
 
-    new HoodieFileScanRDD(sparkSession, baseFileReader, fileSplits)
+    // SPARK-37273 FileScanRDD constructor changed in SPARK 3.3
+    // TODO: Critical change introduced in Spark 3.3, need to test manually
+    sparkAdapter.createHoodieFileScanRDD(sparkSession, baseFileReader, 
fileSplits.map(_.filePartition), requiredSchema.structTypeSchema)
+      .asInstanceOf[HoodieUnsafeRDD]

Review Comment:
   FileScanRDD API changed: 
[SPARK-37273](https://github.com/apache/spark/pull/34575) have to split 
`HoodieFileScanRDD` for different spark versions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to