boneanxs commented on code in PR #6141:
URL: https://github.com/apache/hudi/pull/6141#discussion_r925328888
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSource.scala:
##########
@@ -857,89 +857,6 @@ class TestCOWDataSource extends HoodieClientTestBase {
assertEquals(numRecords - numRecordsToDelete, snapshotDF2.count())
}
- @Test def testFailEarlyForIncrViewQueryForNonExistingFiles(): Unit = {
- // Create 10 commits
- for (i <- 1 to 10) {
- val records = recordsToStrings(dataGen.generateInserts("%05d".format(i),
100)).toList
- val inputDF = spark.read.json(spark.sparkContext.parallelize(records, 2))
- inputDF.write.format("org.apache.hudi")
- .options(commonOpts)
- .option("hoodie.cleaner.commits.retained", "3")
- .option("hoodie.keep.min.commits", "4")
- .option("hoodie.keep.max.commits", "5")
- .option(DataSourceWriteOptions.OPERATION.key(),
DataSourceWriteOptions.INSERT_OPERATION_OPT_VAL)
- .mode(SaveMode.Append)
- .save(basePath)
- }
-
Review Comment:
As we don't need to write same codes(generate data) both in the
`TestCOWDataSource` and `TestMORDataSource`, so move all these codes to the new
test `TestIncrementalReadWithFullTableScan `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
