fengjian428 commented on code in PR #5797:
URL: https://github.com/apache/hudi/pull/5797#discussion_r925653077
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -1557,6 +1557,10 @@ public boolean getHbaseIndexUpdatePartitionPath() {
return
getBooleanOrDefault(HoodieHBaseIndexConfig.UPDATE_PARTITION_PATH_ENABLE);
}
+ public int getHBaseIndexRegionCount() {
+ return getInt(HoodieHBaseIndexConfig.BUCKET_NUMBER);
+ }
+
Review Comment:
I just follow the old way in other HoodieIndex, seems they all have several
getter methods in HoodieWriteConfig and only pass HoodieWriteConfig in the
constructor. Do you think we need to refactor them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
