xiarixiaoyao commented on code in PR #6157:
URL: https://github.com/apache/hudi/pull/6157#discussion_r926485219
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##########
@@ -94,7 +94,8 @@ private FSDataOutputStream getOutputStream() throws
IOException, InterruptedExce
Path path = logFile.getPath();
if (fs.exists(path)) {
boolean isAppendSupported =
StorageSchemes.isAppendSupported(fs.getScheme());
- if (isAppendSupported) {
+ boolean needRollOverToNewFile = fs.getFileStatus(path).getLen() >
sizeThreshold;
+ if (isAppendSupported && !needRollOverToNewFile) {
Review Comment:
hi danny， flushToDiskIfRequired cannot work very well in some situation。
in our product env， the log size will roll up to 30g+
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
