rahil-c commented on code in PR #6151:
URL: https://github.com/apache/hudi/pull/6151#discussion_r927112047


##########
hudi-client/hudi-spark-client/pom.xml:
##########
@@ -174,6 +194,12 @@
       <artifactId>awaitility</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>com.thoughtworks.paranamer</groupId>
+      <artifactId>paranamer</artifactId>
+      <version>2.8</version>
+      <scope>test</scope>
+    </dependency>

Review Comment:
   My assumption is you are referring to this dependency 
https://github.com/paul-hammant/paranamer?
   
       <dependency>
         <groupId>com.thoughtworks.paranamer</groupId>
         <artifactId>paranamer</artifactId>
         <version>2.8</version>
         <scope>test</scope>
       </dependency>
   
   
   this change was made by @xushiyan 
https://issues.apache.org/jira/browse/HUDI-3088 #4752 but i think we need this 
newer 2.8 for spark 3 if its the default profile. In master we have this 
https://github.com/apache/hudi/search?q=paranamer in the licenses we seem to be 
referring to paranamer 2.7
   
   here are some jiras ive seen discussing the issue 
https://github.com/apache/beam/pull/17424  
https://issues.apache.org/jira/browse/BEAM-14345 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to