bvaradar commented on a change in pull request #1150: [HUDI-288]: Add support
for ingesting multiple kafka streams in a single DeltaStreamer deployment
URL: https://github.com/apache/incubator-hudi/pull/1150#discussion_r400016912
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -155,12 +166,20 @@ public Operation convert(String value) throws
ParameterException {
required = true)
public String targetBasePath;
+ @Parameter(names = {"--base-path-prefix"},
Review comment:
@pratyakshsharma : Instead of reusing HoodieDeltaStreamer.Config, Can you
introduce an inner class HoodieMultiTableDeltaStreamer.Config and have all
these configs (duplicated) along with basePathPrefix. When we instantiate
HoodieDeltaStreamer instance in HoodieMultiTableDeltaStreamer, we can create
new instance of HoodieDeltaStreamer.Config by copying all the parameters from
HoodieMultiTableDeltaStreamer.Config. This will avoid introducing a config
parameter in HoodieDeltaStreamer.Config which has only relevance in
HoodieMultiTableDeltaStreamer and keep the CLI parameters for both of them
decoupled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
