yihua commented on code in PR #5430:
URL: https://github.com/apache/hudi/pull/5430#discussion_r928020195
##########
hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestBase.java:
##########
@@ -235,9 +235,8 @@ private TestExecStartResultCallback
executeCommandInDocker(String containerName,
}
int exitCode =
dockerClient.inspectExecCmd(createCmdResponse.getId()).exec().getExitCode();
LOG.info("Exit code for command : " + exitCode);
- if (exitCode != 0) {
- LOG.error("\n\n ###### Stdout #######\n" +
callback.getStdout().toString());
- }
+
+ LOG.error("\n\n ###### Stdout #######\n" +
callback.getStdout().toString());
Review Comment:
Revert the logging changes?
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/MergeOnReadSnapshotRelation.scala:
##########
@@ -47,9 +50,27 @@ class MergeOnReadSnapshotRelation(sqlContext: SQLContext,
override type FileSplit = HoodieMergeOnReadFileSplit
- override lazy val mandatoryFields: Seq[String] =
+ /**
+ * NOTE: These are the fields that are required to properly fulfil
Merge-on-Read (MOR)
Review Comment:
nit: type `fulfil`
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestInsertTable.scala:
##########
@@ -24,6 +24,7 @@ import org.apache.hudi.config.HoodieWriteConfig
import org.apache.hudi.exception.HoodieDuplicateKeyException
import org.apache.hudi.keygen.ComplexKeyGenerator
import org.apache.spark.sql.SaveMode
+import org.apache.spark.sql.internal.SQLConf
Review Comment:
is this used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
