alexeykudinkin commented on code in PR #5430:
URL: https://github.com/apache/hudi/pull/5430#discussion_r928024664
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestInsertTable.scala:
##########
@@ -24,6 +24,7 @@ import org.apache.hudi.config.HoodieWriteConfig
import org.apache.hudi.exception.HoodieDuplicateKeyException
import org.apache.hudi.keygen.ComplexKeyGenerator
import org.apache.spark.sql.SaveMode
+import org.apache.spark.sql.internal.SQLConf
Review Comment:
Good catch! Will address in the PR stacked on top
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/MergeOnReadSnapshotRelation.scala:
##########
@@ -47,9 +50,27 @@ class MergeOnReadSnapshotRelation(sqlContext: SQLContext,
override type FileSplit = HoodieMergeOnReadFileSplit
- override lazy val mandatoryFields: Seq[String] =
+ /**
+ * NOTE: These are the fields that are required to properly fulfil
Merge-on-Read (MOR)
Review Comment:
It's already in that form. Did you mean `fulfill`? Current version is an
American version, why w/ `ll` is the UK one
##########
hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestBase.java:
##########
@@ -235,9 +235,8 @@ private TestExecStartResultCallback
executeCommandInDocker(String containerName,
}
int exitCode =
dockerClient.inspectExecCmd(createCmdResponse.getId()).exec().getExitCode();
LOG.info("Exit code for command : " + exitCode);
- if (exitCode != 0) {
- LOG.error("\n\n ###### Stdout #######\n" +
callback.getStdout().toString());
- }
+
+ LOG.error("\n\n ###### Stdout #######\n" +
callback.getStdout().toString());
Review Comment:
This are intended: these are changes replicated from
https://github.com/apache/hudi/pull/6175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
