xushiyan commented on code in PR #6020:
URL: https://github.com/apache/hudi/pull/6020#discussion_r928069607
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/payload/SqlTypedRecord.scala:
##########
@@ -53,6 +53,11 @@ object SqlTypedRecord {
private val avroDeserializerCache = CacheBuilder.newBuilder().build[Schema,
HoodieAvroDeserializer]()
+ private val avroDeserializerCacheLocal = new ThreadLocal[Cache[Schema,
HoodieAvroDeserializer]] {
+ override def initialValue(): Cache[Schema, HoodieAvroDeserializer] =
+ CacheBuilder.newBuilder().maximumSize(16).build[Schema,
HoodieAvroDeserializer]()
Review Comment:
@KnightChess what i meant was, the current implementation does not use the
cache object it created from `initialValue()`. The objects are put into
`avroDeserializerCache`, which is not from the ThreadLocal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
