codope commented on code in PR #5837:
URL: https://github.com/apache/hudi/pull/5837#discussion_r928149492
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java:
##########
@@ -491,14 +503,33 @@ private Stream<HoodieInstant> getInstantsToArchive() {
// active timeline. This is required by metadata table,
// see HoodieTableMetadataUtil#processRollbackMetadata for details.
if (HoodieTableMetadata.isMetadataTable(config.getBasePath())) {
- HoodieTableMetaClient dataMetaClient = HoodieTableMetaClient.builder()
-
.setBasePath(HoodieTableMetadata.getDatasetBasePath(config.getBasePath()))
+ HoodieTableMetaClient metadataTableMetaClient =
HoodieTableMetaClient.builder()
Review Comment:
you're right. Not sure why `HoodieTableMetadata` has two methods for the
same purpose: `getDatasetBasePath` and `getDataTableBasePathFromMetadataTable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
