vinothchandar commented on a change in pull request #1457: [HUDI-741] Added
checks to validate Hoodie's schema evolution.
URL: https://github.com/apache/incubator-hudi/pull/1457#discussion_r400282621
##########
File path:
hudi-client/src/main/java/org/apache/hudi/client/HoodieWriteClient.java
##########
@@ -457,6 +461,37 @@ private void
saveWorkloadProfileMetadataToInflight(WorkloadProfile profile, Hood
private JavaRDD<WriteStatus> upsertRecordsInternal(JavaRDD<HoodieRecord<T>>
preppedRecords, String commitTime,
HoodieTable<T> hoodieTable, final boolean isUpsert) {
+ if (getConfig().getSchemaCheck()) {
Review comment:
this whole block can be pulled into a private method like `validateSchema()`
and reused? without being inlined into `upsertRecordsInternal()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
