xushiyan commented on code in PR #6197:
URL: https://github.com/apache/hudi/pull/6197#discussion_r928174380
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/BaseProcedure.scala:
##########
@@ -50,7 +50,7 @@ abstract class BaseProcedure extends Procedure {
HoodieWriteConfig.newBuilder
.withPath(basePath)
.withIndexConfig(HoodieIndexConfig.newBuilder.withIndexType(IndexType.BLOOM).build)
- .withRollbackUsingMarkers(false)
+
.withRollbackUsingMarkers(HoodieWriteConfig.ROLLBACK_USING_MARKERS_ENABLE.defaultValue.toBoolean)
Review Comment:
does not look like the right place to change. Looks like the original code
is trying to overwrite and never use marker to rollback. otherwise it'll just
skip setting it. This is for procedure maybe @XuQianJin-Stars can help clarify
if we always want this to be `false`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
