vinothchandar commented on a change in pull request #1402: [WIP][HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#discussion_r400424181
########## File path: hudi-client/src/main/java/org/apache/hudi/index/HoodieIndex.java ########## @@ -118,9 +121,10 @@ protected HoodieIndex(HoodieWriteConfig config) { /** * Each index type should implement it's own logic to release any resources acquired during the process. */ - public void close() {} + public void close() { + } public enum IndexType { - HBASE, INMEMORY, BLOOM, GLOBAL_BLOOM + HBASE, INMEMORY, BLOOM, GLOBAL_BLOOM, SIMPLE Review comment: let's fix it in this itself? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services