nsivabalan commented on a change in pull request #1433: [HUDI-728]: Implement
custom key generator
URL: https://github.com/apache/incubator-hudi/pull/1433#discussion_r400520645
##########
File path: hudi-spark/src/main/java/org/apache/hudi/keygen/KeyGenerator.java
##########
@@ -40,4 +40,22 @@ protected KeyGenerator(TypedProperties config) {
* Generate a Hoodie Key out of provided generic record.
*/
public abstract HoodieKey getKey(GenericRecord record);
+
+ public abstract String getPartitionPath(GenericRecord record, String
partitionPathField);
+
+ public abstract String getRecordKey(GenericRecord record);
+
+ public enum PartitionKeyType {
Review comment:
ah, you have defined an enum. May I know why using strings back there ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
