codope commented on code in PR #5771:
URL: https://github.com/apache/hudi/pull/5771#discussion_r929771243
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -622,9 +623,10 @@ object DataSourceWriteOptions {
/** @deprecated Use {@link PRECOMBINE_FIELD} and its methods instead */
@Deprecated
val PRECOMBINE_FIELD_OPT_KEY = HoodieWriteConfig.PRECOMBINE_FIELD_NAME.key()
- /** @deprecated Use {@link PRECOMBINE_FIELD} and its methods instead */
+ /** @deprecated Use {@link PRECOMBINE_FIELD} and its methods instead.
+ * This field has no default value since version 0.12.0, `ts` is
for backward compatibility. */
@Deprecated
- val DEFAULT_PRECOMBINE_FIELD_OPT_VAL = PRECOMBINE_FIELD.defaultValue()
+ val DEFAULT_PRECOMBINE_FIELD_OPT_VAL = "ts"
Review Comment:
It's there just for BWC. Will take it in a separate PR that removes all
deprecated configs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
