vinothchandar commented on a change in pull request #1406: [HUDI-713] Fix 
conversion of Spark array of struct type to Avro schema
URL: https://github.com/apache/incubator-hudi/pull/1406#discussion_r400537729
 
 

 ##########
 File path: hudi-spark/src/main/scala/org/apache/hudi/AvroConversionHelper.scala
 ##########
 @@ -338,12 +337,13 @@ object AvroConversionHelper {
         }
       case structType: StructType =>
         val schema: Schema = SchemaConverters.toAvroType(structType, nullable 
= false, structName, recordNamespace)
+        val childNameSpace = if (recordNamespace != "") 
s"$recordNamespace.$structName" else structName
 
 Review comment:
   I mean its a nit.. not sure if the line being in spark would change how feel 
about it.. but again its a nit, happy to let this be this way :) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to