xushiyan commented on a change in pull request #1440: [HUDI-731] Add ChainedTransformer URL: https://github.com/apache/incubator-hudi/pull/1440#discussion_r400558170
########## File path: hudi-utilities/src/test/java/org/apache/hudi/utilities/TestUtilHelpers.java ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.utilities; + +import org.apache.hudi.common.config.TypedProperties; +import org.apache.hudi.utilities.transform.ChainedTransformer; +import org.apache.hudi.utilities.transform.Transformer; + +import org.apache.spark.api.java.JavaSparkContext; +import org.apache.spark.sql.Dataset; +import org.apache.spark.sql.Row; +import org.apache.spark.sql.SparkSession; +import org.junit.Rule; +import org.junit.Test; +import org.junit.experimental.runners.Enclosed; +import org.junit.rules.ExpectedException; +import org.junit.runner.RunWith; + +import java.io.IOException; +import java.util.Arrays; +import java.util.Collections; +import java.util.List; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNull; +import static org.junit.Assert.assertTrue; + +@RunWith(Enclosed.class) +public class TestUtilHelpers { + + public static class TestCreateTransformer { Review comment: @yanghua That's the intended usage of `@RunWith(Enclosed.class)`, which is to run enclosed static classes separately. I think we should logically segregate tests for different utility methods in `UtilHelpers`, due to its versatility. E.g., only `TestCreateTransformer` should know about `TransformerFoo.class` and `TransformerBar.class` hence they are enclosed in this static class so that other test cases don't worry about them. Sounds reasonable? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
