yanghua commented on code in PR #6144:
URL: https://github.com/apache/hudi/pull/6144#discussion_r930831757
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java:
##########
@@ -21,6 +21,8 @@
public enum CompactionTriggerStrategy {
// trigger compaction when reach N delta commits
NUM_COMMITS,
+ // trigger compaction when reach N delta commits since last compaction
request
+ NUM_COMMITS_AFTER_REQUEST,
Review Comment:
should we emphasize the "LAST" semantic?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/ScheduleCompactionActionExecutor.java:
##########
@@ -140,6 +140,17 @@ private Option<Pair<Integer, String>>
getLatestDeltaCommitInfo() {
return Option.empty();
}
+ private Option<Pair<Integer, String>>
getLatestDeltaCommitInfoSinceCompactionRequest() {
Review Comment:
getDeltaCommitInfoSinceLastCompactionRequest?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/ScheduleCompactionActionExecutor.java:
##########
@@ -140,6 +140,17 @@ private Option<Pair<Integer, String>>
getLatestDeltaCommitInfo() {
return Option.empty();
}
+ private Option<Pair<Integer, String>>
getLatestDeltaCommitInfoSinceCompactionRequest() {
+ Option<Pair<HoodieTimeline, HoodieInstant>> deltaCommitsInfo =
Review Comment:
deltaCommitsInfo or deltaCommitInfo?
##########
hudi-common/src/main/java/org/apache/hudi/common/util/CompactionUtils.java:
##########
@@ -237,6 +237,36 @@ public static Option<Pair<HoodieTimeline, HoodieInstant>>
getDeltaCommitsSinceLa
}
}
+ public static Option<Pair<HoodieTimeline, HoodieInstant>>
getDeltaCommitsSinceLatestCompactionRequest(
Review Comment:
ditto, Commits or Commit?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/ScheduleCompactionActionExecutor.java:
##########
@@ -157,6 +168,18 @@ private boolean needCompact(CompactionTriggerStrategy
compactionTriggerStrategy)
LOG.info(String.format("The delta commits >= %s, trigger compaction
scheduler.", inlineCompactDeltaCommitMax));
}
break;
+ case NUM_COMMITS_AFTER_REQUEST:
+ latestDeltaCommitInfoOption =
getLatestDeltaCommitInfoSinceCompactionRequest();
+
+ if (!latestDeltaCommitInfoOption.isPresent()) {
+ return false;
+ }
+ latestDeltaCommitInfo = latestDeltaCommitInfoOption.get();
+ compactable = inlineCompactDeltaCommitMax <=
latestDeltaCommitInfo.getLeft();
+ if (compactable) {
+ LOG.info(String.format("The delta commits >= %s, trigger compaction
scheduler.", inlineCompactDeltaCommitMax));
Review Comment:
`%s since the last compaction request`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
